trace-resources: move from cardano-node as hermod-trace-resources#14
Open
jutaro wants to merge 2 commits into
Open
trace-resources: move from cardano-node as hermod-trace-resources#14jutaro wants to merge 2 commits into
jutaro wants to merge 2 commits into
Conversation
Adds the hermod-trace-resources package (moved from IntersectMBO/cardano-node). Module namespace renamed from Cardano.Logging.Resources.* to Hermod.Tracing.Resources.*.
mgmeier
previously approved these changes
Jun 22, 2026
mgmeier
left a comment
mgmeier
left a comment
Contributor
There was a problem hiding this comment.
Please add a package import one-liner to the project-wide changelog.
| ```haskell | ||
| tr <- mkCardanoTracer trBase mempty ["Resources"] [EKGBackend] | ||
| configureTracers initialTraceConfig trDocumented [tr] | ||
| forM_ [1..] $ \_ -> do |
Contributor
There was a problem hiding this comment.
straighten out hallucinations
mgmeier
requested changes
Jun 22, 2026
mgmeier
left a comment
mgmeier
left a comment
Contributor
There was a problem hiding this comment.
2 small issues, see above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the hermod-trace-resources package, moved from IntersectMBO/cardano-node. The package provides cross-platform (Linux, macOS, Windows) OS-level resource sampling — CPU ticks, GC stats, memory (RSS/heap/live), network I/O, filesystem I/O, and thread count — for use by the node and tracer.
Two changes accompany the move:
Package name: trace-resources → hermod-trace-resources
Module namespace: Cardano.Logging.Resources.* → Hermod.Tracing.Resources.*
All source logic, platform-specific C bindings, cabal flags (with-netstat), tests, and benchmarks are preserved unchanged.
Changes
New package hermod-trace-resources/ with renamed cabal file and module tree under src/Hermod/Tracing/
cabal.project: add hermod-trace-resources
perSystem/packages.nix: expose library and test check
perSystem/project.nix: add -Werror -fno-ignore-asserts for new package
perSystem/devShells.nix: add package to dev shell